GSW-1012 feat: conditions for external incentive start time #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row midnight(and midnight of the day)
r3v4s
changed the title
- due to this, result of reward amount has been changed
r3v4s
force-pushed
the
GSW-1012-feat-start-time-of-external-incentive-must-be-at-least-tomorrow-midnight
branch
from
68ac821
to
8bba9a3
Compare
notJoon
reviewed
Apr 11, 2024
notJoon
approved these changes
Apr 11, 2024
notJoon
deleted the
GSW-1012-feat-start-time-of-external-incentive-must-be-at-least-tomorrow-midnight
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
start time of
CreateExternalIncentivemust satisfy following conditions1.1 Must be same or bigger(later ≈ future) than tomorrow midnight.
1.2 Must be midnight of day
new api function for incentive lists
Test